[indexedArray] es6-ify #11800
Merged
[indexedArray] es6-ify #11800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
es6-ify/indexed_array
branch
from
b4a11cf
to
3f2e2dd
Compare
ppisljar
reviewed
May 15, 2017
| if (config.immutable) { | ||
| // just a hint, bugs caused by updates not propogating would be very | ||
| // very very hard to track down | ||
| this.push = this.splice = undefined; |
There was a problem hiding this comment.
was loosing this intentional ?
There was a problem hiding this comment.
Yeah, they are now implemented as methods and throw descriptive errors when immutable is turned on (it also covers all of the mutable methods, not just push and splice).
spalger
force-pushed
the
es6-ify/indexed_array
branch
from
3f2e2dd
to
0fc075e
Compare
spalger
added a commit
that referenced
this pull request
May 15, 2017
(cherry picked from commit 12e56b8)
|
5.x/5.5: 367babc |
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just refactored the IndexedArray class to be an es6 class