-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[indexedArray] es6-ify #11800
[indexedArray] es6-ify #11800
Conversation
b4a11cf
to
3f2e2dd
Compare
if (config.immutable) { | ||
// just a hint, bugs caused by updates not propogating would be very | ||
// very very hard to track down | ||
this.push = this.splice = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was loosing this intentional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they are now implemented as methods and throw descriptive errors when immutable is turned on (it also covers all of the mutable methods, not just push and splice).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3f2e2dd
to
0fc075e
Compare
(cherry picked from commit 12e56b8)
5.x/5.5: 367babc |
Just refactored the IndexedArray class to be an es6 class